Home page logo

bugtraq logo Bugtraq mailing list archives

Re: QPOPPER problem.... ONE crude patch...
From: ryde () TRIPNET SE (Daniel Ryde)
Date: Sat, 27 Jun 1998 18:31:05 +0200

On Sat, 27 Jun 1998, Tom Brown wrote:

        vsnprintf(mp,sizeof(message)-(mp - message)-3,format,ap);

Dangerous, if the string is truncated it will skip the null termination,
then later the strcat might fail miserably (unless all arcitectures makes
for sure that, when allocated, the string is filled with null, which I
really doubt). Another note is the next lines of sprintf (architectures
that dont have vsprintf) that will have the same problem as vsprintf.
Change these to snprintf in a similar way, and add a null to the end.

Best Regards

Daniel Ryde, System Administrator
Tripnet AB                Visit Address:      Telephone:  +46 31 7252500
Box 5071                  Avagen 42           Facsimile:  +46 31 7252501
S-402 22 GOTEBORG         GOTEBORG            Email:      ryde () tripnet se
Sweden                    Sweden

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]