Nmap Development: Re: Nmap 3.84ALPHA1: Call For Testers

[Ron <iago () valhallalegends com>]

Works great, thanks :)

doug () hcsw org wrote:
> Hi Ron and nmap-dev,
>
> I've found the source of the -sVU bug and I've attached a patch that fixes it. It turned out to be an embarassing 
> off-by-one bug and I'm grateful that it was caught before a more formal release was made.
>
> I've attached a unified diff patch that you can apply to the BETA version like so:
>
> doug () neutrino:~/nmap-3.84ALPHA1$ patch -p1 < /patch/to/nmap-3.84ALPHA1-udp-fix.patch
> patching file service_scan.cc
> doug () neutrino:~/nmap-3.84ALPHA1$
>
> and recompiling.
>
> Fyodor, I've also put the fix into CVS.
>
> Thanks a lot for the bug report Ron!
>
> Doug
>
>
> ------------------------------------------------------------------------
>
> diff -urNb old.nmap.rev/service_scan.cc new.nmap.rev/service_scan.cc
> --- old.nmap.rev/service_scan.cc      2005-08-25 11:59:09.354737080 -0700
> +++ new.nmap.rev/service_scan.cc      2005-08-25 11:59:09.475718688 -0700
> @@ -1169,7 +1169,7 @@
>  // scan protocols.
>  int AllProbes::isExcluded(unsigned short port, int proto) {
>    unsigned short *p=NULL;
> -  int count=-1;
> +  int count=-1,i;
>  
>    if (proto == IPPROTO_TCP) {
>      p = excludedports->tcp_ports;
> @@ -1181,8 +1181,9 @@
>      fatal("Bad proto number (%d) specified in AllProbes::isExcluded", proto);
>    }
>  
> -  for (;count >= 0;count--)
> -    if (p[count] == port) return 1;
> +  for (i=0; i<count; i++)
> +    if (p[i] == port)
> +         return 1;
>  
>    return 0;
>  }

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev