Home page logo
/

nmap-dev logo Nmap Development mailing list archives

[PATCH] Questionable value in in ll2shortascii() in tcpip.cc
From: "Kris Katterjohn" <kjak () ispwest com>
Date: Tue, 21 Feb 2006 15:15:46 -0800

This changes 10000 to 1000 in ll2shortascii(). I'm not sure if it was intended to
use 10,000 instead of 1,000 for KB. Of course, it could be fine just using B for
less than 10,000 since it still won't be a huge number, but it that were the
case, maybe MB should be pushed up to 10,000,000 instead of 1,000,000.

My bet is that it was a typo.

Thanks,
Kris Katterjohn


--- tcpip.cc.orig       2006-02-21 11:55:49.000000000 -0600
+++ tcpip.cc    2006-02-21 17:05:00.000000000 -0600
@@ -183,7 +183,7 @@ static char *ll2shortascii(unsigned long
 
   if (bytes > 1000000) {
     snprintf(buf, buflen, "%.3gMB", bytes / 1000000.0);
-  } else if (bytes > 10000) {
+  } else if (bytes > 1000) {
     snprintf(buf, buflen, "%.3gKB", bytes / 1000.0);
   } else snprintf(buf, buflen, "%uB", (unsigned int) bytes);
     




_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev


  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]