mailing list archives
Re: [PATCH] Questionable value in in ll2shortascii() in tcpip.cc
From: "Kris Katterjohn" <kjak () ispwest com>
Date: Tue, 21 Feb 2006 15:57:49 -0800
Sent: 2/21/2006 3:46:35 PM
On Tue, Feb 21, 2006 at 03:15:46PM -0800, Kris Katterjohn wrote:
This changes 10000 to 1000 in ll2shortascii(). I'm not sure if it was intended to
use 10,000 instead of 1,000 for KB. Of course, it could be fine just using B for
less than 10,000 since it still won't be a huge number, but it that were the
case, maybe MB should be pushed up to 10,000,000 instead of 1,000,000.
This is actually intentional, though I'm open to arguments from people
who think printing that Nmap sent "3.92KB" would be better than
"3917B". The latter is shorter and more precise. The "B" measurement
gets one extra order of magnitude to make up for "B" being one
character shorter than "KB" or "MB".
Nah, the current way looks fine to me. I didn't think about the B being shorter
than the KB and MB, so now it makes more sense.
Sent through the nmap-dev mailing list