Hello Thomas,
On 13.06.2007, at 04:52, Thomas Buchanan wrote:
>
> All my scripts have been sent as attachments, and show up as such in
> both of my mail clients (Outlook and Thunderbird):
>
> Content-Type: text/plain;
> name="MSSQLVersion.nse"
> Content-Transfer-Encoding: 7bit
> Content-Disposition: inline;
> filename="MSSQLVersion.nse"
>
> Not sure why you are not seeing them that way. Perhaps the
> Content-Disposition header for the attachment? I'll check the options
> on my mailer to see if I can change that setting.
I am sorry then :) I need to look into my email client then.
> I guess the main reason that the get_real_version() function is inside
> action() is because it uses a socket variable that is defined
> inside the
> action() namespace. Maybe that's poor programming practice on my
> part,
> but it seemed to work fine, and I didn't think too much about it. I'm
> happy to rework the script to move that function into it's own name
> space if it makes it more readable / maintainable.
It's not at all poor programming. Using a variable which is in the
local scope is a perfectly good reason to do it your way. Depending
on how things turn out with our SoC NSE coder your script might
undergo some refactoring prior to being merged with the nmap unstable
branch but it's nothing to worry about.
cheers,
Diman
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org
Received on Jun 13 2007