mailing list archives
Re: [PATCH] Report more accurate host start and end times
From: Brandon Enright <bmenrigh () ucsd edu>
Date: Thu, 8 May 2008 05:30:48 +0000
-----BEGIN PGP SIGNED MESSAGE-----
On Thu, 8 May 2008 09:06:56 +0530 or thereabouts "Kris Katterjohn"
<katterjohn () gmail com> wrote:
On Thu, May 8, 2008 at 7:37 AM, Brandon Enright <bmenrigh () ucsd edu>
I've cleaned up this patch (attached). Rather than output the very
long host time line like before, the line now looks like:
Scanned at 2008-05-08 01:57:19 UTC for 1s
Also, a verbosity level of 2 or greater is now required. The
information is always reported in the XML output.
I like this idea, especially with the shorter line. However there are
a couple of things I noticed:
1) Windows doesn't seem to support the %T conversion; doing %H:%M:%S
Thanks for catching this; good to know.
2) How about printing the message if o.verbose > 1 || o.debugging ?
I considered the same thing but I didn't want to add to -d being a more
verbose version of verbose -- I suppose the information may be useful
for whatever people use -d for but I thought that just verbose would be
I always run with -v and -d but rarely -vv so you're probably right
that the change is appropriate.
I've attached a patch including these changes.
Looks good, thanks for looking at (and fixing up) the patch.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
-----END PGP SIGNATURE-----
Sent through the nmap-dev mailing list
Archived at http://SecLists.Org