Nmap Development: Re: [PATCH] lil' mistake in stdnse.lua

[jah <jah () zadkiel plus com>]

On 22/06/2008 19:39, Patrick Donnelly wrote:
> Hi Jah,
>
> I beileve I've fixed this now. Could you please try again?
>
> Thanks,
Hi Patrick,

I believe you have, nice work!  I've tested it and get no errors and
print_debug() is working again.

Would you please apply the attached patch to http.lua, because I messed-up.
Previously there was this in a loop to read from a buffer:

    status, line = buffer()
    if (not status or line == "") then break end

and I sent a patch to make it:

    line = buffer()
    if not line then break end

which should have been:

    line = buffer()
    if (not line or line == "") then break end

otherwise an empty string doesn't get detected as a break between an
http header and the body and it reads the entire response into the
header table.  Whoops.

Cheers,

jah

--- http.lua.orig       2008-06-21 22:22:12.390625000 +0100
+++ http.lua    2008-06-23 01:05:37.750000000 +0100
@@ -110,7 +110,7 @@
   -- header loop
   while true do
     line = buffer()
-    if not line then break end
+    if (not line or line == "") then break end
     table.insert(header,line)
   end
 

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org