Nmap Development: Re: [NSE + NSELib] Netbios and SMB [stable!]

[Ron <ron () skullsecurity net>]

David Fifield wrote:
> On Fri, Sep 12, 2008 at 02:33:13PM -0500, Ron wrote:
> I added the new modules and scripts. Thanks! They all look well done,
> especially the documentation. I tested them this morning and they are
> are an improvement over what was there before.
Thanks!

> I adjusted the categories of the SMB scripts as follows:
>
> smb-os-discovery.nse
> -categories = {"version","default"}
> +categories = {"default", "discovery", "safe"}
>
> smb-enum.nse
> -categories = {"version","intrusive"}
> +categories = {"discovery", "intrusive"}
>
> smb-security-mode.nse
> -categories = {"version"}
> +categories = {"discovery", "safe"}
>
> The "version" category is only for getting results like what -sV gets.
> Scripts in the "version" category should produce output by assigning
> port.version.name, port.version.product, and other fields, and they
> shouldn't produce any normal script output. Because these new scripts
> don't work that way I put them in "discovery" instead.
Good call, I was going to go back and fix the categories but forgot.
Thanks for fixing!

> I saw one missed opportunity to use nselib. In smb-enum.nse you can use
> stdnse.strjoin instead of the custom function string_join.
Aha, I was surprised there wasn't a better version around. I only
discovered stdnse recently.

> I think asking for the server's name in a script argument is just fine.
Cool, I might do that next version.

> David Fifield

Ron

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org