Home page logo

nmap-dev logo Nmap Development mailing list archives

Re: [NSE] http library cookie bug
From: David Fifield <david () bamsoftware com>
Date: Tue, 15 Mar 2011 14:37:10 -0700

On Tue, Mar 15, 2011 at 09:18:04PM +0100, John Bond wrote:
On 15 March 2011 20:33, Patrik Karlsson <patrik () cqure net> wrote:

I think I ran into a bug when testing some code that handles cookies.
As far as I can understand from RFC 2109 "Attributes (names) (attr) are case-insensitive."

When the http-library parses the cookie, each name value pair is processed and a table field is dynamically created 
using the following code:
cookie[name] = value

I'm testing against two different servers. One returns the cookie path value all lowercase and the second using a 
leading capital P.
I think it would make more sense if the cookie attributes were always stored using lowercase table field names.
So I propose the following patch:

- cookie[name] = value
+ cookie[name:lower()] = value

Im not familiar with the specifics of the cookie rfc's however in http
1.1 paths should be considered case-sensitive[1] so i suspect it is
the same for the path part of the http cookie

Patrik is talking about the string "Path" or "path", not the path
itself. Patrik, I think your change makes sense and you can do it. It
will be just like the way we handle header fields.

David Fifield
Sent through the nmap-dev mailing list
Archived at http://seclists.org/nmap-dev/

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]