Home page logo

nmap-dev logo Nmap Development mailing list archives

Re: [NSE] ip-geolocation
From: Gorjan Petrovski <mogi57 () gmail com>
Date: Tue, 14 Jun 2011 14:36:48 +0200

o The gmtime() function can simply be:


I think there was also an error somewhere in your gmtime function
because the two produce different results.

The results are off by one hour. AFAIK my calculations are ok, unless
my mind's slipped :P
The os.time(os.date("!*t")) doesn't give the time which may be used by
the Quova API, the gmtime() and ostime() functions do. I'll research
this a bit later, I've left the gmtime() as is. I'd like to explore
lldp and lltd before the meeting.

o The name for your "const" table worries me. Can you change it to
something else that doesn't resemble a C keyword? :)


Overall I like the script. Is there a reason you didn't elect to go
with separate scripts with "subnames"

That was a good idea that I overlooked. As you may notice by the
attachments I've split the files.

Gorjan Petrovski

Attachment: ip-geolocation-geobytes.nse

Attachment: ip-geolocation-geoplugin.nse

Attachment: ip-geolocation-ipinfodb.nse

Attachment: ip-geolocation-maxmind.nse

Attachment: ip-geolocation-quova.nse

Sent through the nmap-dev mailing list
Archived at http://seclists.org/nmap-dev/

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]