mailing list archives
Analysis of clang results against the nmap-npingchanges branch for nping directory only.
From: James Rogers <jamesmrogers () gmail com>
Date: Wed, 13 Jun 2012 14:05:55 -0400
Only found two real issues:
API Argument with 'nonnull' attribute passed null nping
/common_modified.cc 490 20
490 s = strchr(addy[i],',');
20 Null pointer passed as an argument to a 'nonnull' parameter
Is a bug. hostexp is never checked to make sure it is not NULL.
371 char *hostexp = strdup(target_expr);
386 addy = addy = addy = addy = addy = NULL;
387 addy = r = hostexp;
Dead store Dead assignment nping /EchoServer.cc 1507 1
1507 loopret=nsock_loop(nsp, 1000);
Value stored to 'loopret' is never read
This is a bug. Easy to fix.
There were a lot more references to loopret that have been removed in
this branch, this looks like the last one remaining.
The rest of the bugs were generated by clang not recognizing that
nping_fatal() and fatal() do not return.
Sent through the nmap-dev mailing list
Archived at http://seclists.org/nmap-dev/
- Analysis of clang results against the nmap-npingchanges branch for nping directory only. James Rogers (Jun 13)