Home page logo

nmap-dev logo Nmap Development mailing list archives

Re: [NSE] http-git patches
From: David Fifield <david () bamsoftware com>
Date: Wed, 12 Dec 2012 20:18:57 -0800

On Tue, Dec 11, 2012 at 03:50:50PM -0600, Alex Weber wrote:
Thank-you for doing that bisection and fixing the problem.

I made the changes you suggested, and a lot of code was touched, so the
patches are big. While making the changes, I had a code review done and
made some style changes to enhance readability and bring http-git closer
to the style of the other NSE scripts.

Excellent job, Alex. These changes look great. I applied them in r30386.

The way you handled the patches was fine.

David Fifield
Sent through the dev mailing list
Archived at http://seclists.org/nmap-dev/

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]