Home page logo
/

nmap-dev logo Nmap Development mailing list archives

Re: [NSE] isakmp aggressive mode and version detection
From: Jesper Kückelhahn <dev.kyckel () gmail com>
Date: Tue, 29 Jan 2013 22:22:30 +0100

Hi,

Attached are two unified patches for ike.lua and ike-version.nse. The patch
for ike.lua changes hex strings to standard hex notation, and
ike-version.nse.patch corrects an error in the description of the script.

- Jesper

On Mon, Jan 28, 2013 at 7:00 PM, David Fifield <david () bamsoftware com>wrote:

On Mon, Jan 28, 2013 at 05:33:36PM +0100, Jesper Kückelhahn wrote:
Thanks for the commit.

I used hex strings as I thought that it would improve the readability
and easy of modification. I'd gladly change it if the other method is
better suited.

Yes, please do; the style otherwise stands out from other libraries.
Feel free to use hex for input or output, but the canonincal in-memory
format should be binary.

David Fifield

Attachment: ike-version.nse.patch
Description:

Attachment: ike.lua.patch
Description:

_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]