Home page logo

nmap-dev logo Nmap Development mailing list archives

Re: Match ICMP echo reply to request in scan_engine.cc
From: Chris Johnson <cjohnson () zenoss com>
Date: Thu, 08 Aug 2013 16:00:37 -0400 (EDT)

http://git.io/nmap-cjohnson-2.diff (also attached)

David Fifield, thanks for the good feedback.

1. You're correct, ping->seq is always zero (so it's erroneous to check for it).
2. I disagree with the suggestion of storing icmp_ident in probespec_icmpdata. The ident value is (ideally) unique to 
each probe.
3. I've created an icmp_probe_match helper function, as suggested.

 - chris

Attachment: nmap-cjohnson-2.diff

Sent through the dev mailing list
Archived at http://seclists.org/nmap-dev/

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]