Home page logo

nmap-dev logo Nmap Development mailing list archives

Re: [nmap-svn] r32398 - in nmap: ncat nsock/src
From: David Fifield <david () bamsoftware com>
Date: Thu, 26 Sep 2013 19:12:00 -0700

On Thu, Sep 26, 2013 at 09:15:19AM -0500, Daniel Miller wrote:
On 09/26/2013 02:17 AM, commit-mailer () nmap org wrote:
-                if ((tmp_name = tempnam(NULL, "ncat.")) == NULL)
+                if ((tmp_name = tempfile(NULL, "ncat.")) == NULL)
                     bye("Failed to create name for temporary DGRAM source Unix domain socket (tempnam).");

Should the error message here also be changed, since we're not using
tempnam any more? If so, should it be "tempfile" or "mkstemp"?

Sure, please go ahead and change it to mkstemp.

I added an implementation of tempfile for Windows using tempnam, but it
isn't called by Ncat because you don't have Unix domain sockets on

David Fifield
Sent through the dev mailing list
Archived at http://seclists.org/nmap-dev/

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]