Home page logo
/

nmap-dev logo Nmap Development mailing list archives

Re: NCAT: SOCKS5 patch
From: Petr Stodůlka <pstodulk () redhat com>
Date: Thu, 13 Feb 2014 14:12:45 +0100

2014-02-09 14:51 GMT+01:00 Henri Doreau <henrireau () gmail com >:
Thanks, good job!

I checked it in (r32707), with a single change: resolve_internal()
takes `port' as an unsigned short though it was declared as taking it
as unsigned short *.

Any reason why getaddrfamily()  returns -1, 1 or 2 instead of usual
constants AF_INET and AF_INET6? If not I'd like to change that.

A last thing: could you please update the documentation in
ncat/docs/ncatguide.xml?

Regards

Hi Henri,
Thanks for feedback. Yes, 'unsigned short *' was mistake. I did update of getaddrfamily() (now returns -1, AF_INET, AF_INET6) and documentation for actual revision (r32717).

Regards,
Petr
_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/


  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]