Home page logo
/

nmap-dev logo Nmap Development mailing list archives

Re: [Patch] Update libpcap to 1.5.3; Also discussion on whether we should really bundle 3rd party libraries or not
From: Jay Bosamiya <jaybosamiya () gmail com>
Date: Fri, 06 Jun 2014 16:14:12 +0530

Dan,

I had tried checking whether the issues have been addressed upstream,
but back in March, the only way I had checked is by seeing if any of the
patches were applied to libpcap 1.5.3 release directly. Following that,
I hadn't really looked into this too much. My bad.

Point noted: I will do better checking in the future.

I have committed in libpcap 1.5.3 with only the pre-configure.patch,
0001-*.patch and 0002-*.patch applied. (r32966)

Cheers,
Jay

On Friday 06 June 2014 01:42 AM, Daniel Miller wrote:
Jay,

We need to do better checking on whether these issues have been
addressed upstream. Patch
0004-Include-netpacket-packet.h-before-pcap-bpf.h.patch for instance
was addressed in libpcap 1.4.1, as evidenced by this issue on GitHub
(https://github.com/the-tcpdump-group/libpcap/issues/306) and our own
CHANGELOG, which notes the upstream fix which was not in a release in
2008.

Patch 0003 was actually in response to a Valgrind bug, which has been
fixed in Valgrind upstream
(https://github.com/the-tcpdump-group/libpcap/issues/147 and
https://bugs.kde.org/show_bug.cgi?id=318203)

I've opened a pull request
(https://github.com/the-tcpdump-group/libpcap/pull/358) with upstream
for the --disable-packet-ring one, though I don't see how it affects
Nmap unless it's used for building the RPM binary packages for releases.

I also opened a pull request
(https://github.com/the-tcpdump-group/libpcap/pull/359) with upstream
for the pre-configure.patch issue on AIX. We'll see what they say.

Patch 0001 is simply to keep our SVN history clean, since folks with
different bison/flex versions could conceivably generate different
files, which would lead to unnecessary check-ins of "changes" to those
files. When you do rebuild those files with the new version of
libpcap, please use bison 2.5 or newer, since that is the version that
was used with the previous generation.

That said, I think that you can go ahead and commit the upgrade. You
should have pre-configure.patch, 0001-*.patch, and 0002-*.patch
applied. If you would like review on the modifications to those
patches, please ask. Thanks for your work!

Dan

_______________________________________________
Sent through the dev mailing list
http://nmap.org/mailman/listinfo/dev
Archived at http://seclists.org/nmap-dev/


  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]
AlienVault