Home page logo
/

wireshark logo Wireshark mailing list archives

Re: [Wireshark-commits] rev 47064: /trunk/epan/ /trunk/epan/: CMakeLists.txt
From: Joerg Mayer <jmayer () loplof de>
Date: Mon, 22 Apr 2013 21:06:05 +0200

Hi,

sorry to review this so late:

On Mon, Jan 14, 2013 at 03:39:39PM +0000, cmaynard () wireshark org wrote:
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=47064

User: cmaynard
Date: 2013/01/14 07:39 AM

Log:
 packet-ncp2222.c -> dissectors/packet-ncp2222.c

Directory: /trunk/epan/
  Changes    Path              Action
  +1 -1      CMakeLists.txt    Modified

Is there reason to make that change (and the subsequent change by gerald)?
packet-ncp2222.c is a generated file and generated files do not belong into
the source tree. If you feel it belongs into the source tree, it should be
checked into svn. As long as we do not do that, it should be built in the
build tree and not the source tree. *Nothing* should be *built* in the source
tree. We should be able to compile with a source tree that is read only.
If we can't do that with autofoo, that's one thing (actually even that works
once you only consider the ./configure && make stuff), but it's perfectly
possible with cmake.

Ciao
       Jörg
-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]