Home page logo

wireshark logo Wireshark mailing list archives

RFC: Any reason not to do this?
From: Martin Mathieson <martin.r.mathieson () googlemail com>
Date: Tue, 23 Apr 2013 16:23:38 -0400

In a profile, I was surprised to see that > 2.5% of time was spent calling
dissect_sip_tcp_heur().  There are no SIP PDUs in the log.  HTTP was very

Does the attached change look reasonable?  It does a quick check for the
first character being printable before trying to extract the first line and
check it for NULL characters.


Attachment: packet-sip.c.diff

Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]