mailing list archives
From: Pascal Quantin <pascal.quantin () gmail com>
Date: Mon, 12 Aug 2013 10:54:20 +0200
2013/8/10 Martin Kaiser <lists () kaiser cx>
I came across this while browsing through the coverity defects.
gboolean first = TRUE; is never changed
Does the following change make sense to those who are familiar with SIP?
diff --git a/epan/dissectors/packet-sip.c b/epan/dissectors/packet-sip.c
index fa317c8..c04a0c8 100644
@@ -2104,6 +2104,7 @@ dissect_sip_tcp_heur(tvbuff_t *tvb, packet_info
*pinfo, proto_tree *tree, void *
if (len == -1)
break; /* need more data */
offset += len;
+ first = FALSE;
I'm not really familiar with SIP over TCP (in all my use cases, SIP is over
UDP) but your proposal makes sense.
Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org>
mailto:wireshark-dev-request () wireshark org?subject=unsubscribe