Home page logo
/

wireshark logo Wireshark mailing list archives

Re: Remove hf_ variables
From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Tue, 13 Aug 2013 18:53:42 +0200

On Fri, Aug 09, 2013 at 08:31:02PM +0200, Jakub Zawadzki wrote:
On Wed, Aug 07, 2013 at 08:10:21PM +0200, Jakub Zawadzki wrote:
I wrote some ugly gawk program for hf_ variables.

Here is one + some patch for epan:
http://www.wireshark.org/~darkjames/proto-new/0001-changes.txt

Here is convertion of some dissectors (not quite automagic):
http://www.wireshark.org/~darkjames/proto-new/0002-rewrite.txt

We probably don't want this redefine macros inside proto-new.h but it's *much faster*
to test.

Removed in v2:

http://www.wireshark.org/~darkjames/proto-new-v2/0001-changes.txt
http://www.wireshark.org/~darkjames/proto-new-v2/0002-rewrite.txt

Changes from v1:
 - proto_tree_add_item() now takes pointer to header_field_info *, 
   if NEW_PROTO_TREE_API NOT defined small compatilibity macro is used.
 - convert names just to hfi_ not hfi_hf_
 - fix proto_get_first_protocol_field(), proto_get_next_protocol_field()

Ping, any feedback?

Also missing final approval/reject (/me smiles to Gerald) ;]
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]