mailing list archives
Taps should not use fd->flags.passed_dfilter (rtp, iax2, flow_analysis)
From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Thu, 15 Aug 2013 14:04:27 +0200
Few GTK taps are using fd->flags.passed_dfilter as information whether
given packet is displayed, this is little broken and might not work as intended.
flow_graph requres clicking OK to trigger graph_analysis_update()
so it doesn't change when refiltering
(but if you close file and click some packet it'll nicely crash :)).
but if you are doing some rtp analysis and do refiltering like:
frame.number == 1
## nothing changes
frame.number == 2
## only frame #1 shows in stream analysis
## only frame #2 shows in stream analysis
## all frames from rtp stream shows up
I don't have any iax2 capture file but it's probably broken like above.
Conversations tap and 'limit to display filter' is implemented properly (gratz!)
Attaching patch based on it.
I'm not doing any rtp analysis, so please advice if it's proper way.
Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org>
mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
- Taps should not use fd->flags.passed_dfilter (rtp, iax2, flow_analysis) Jakub Zawadzki (Aug 15)