Home page logo
/

wireshark logo Wireshark mailing list archives

Re: Remove hf_ variables
From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Sat, 17 Aug 2013 00:58:45 +0200

On Tue, Aug 13, 2013 at 06:53:42PM +0200, Jakub Zawadzki wrote:
On Fri, Aug 09, 2013 at 08:31:02PM +0200, Jakub Zawadzki wrote:
Removed in v2:

http://www.wireshark.org/~darkjames/proto-new-v2/0001-changes.txt
http://www.wireshark.org/~darkjames/proto-new-v2/0002-rewrite.txt

Changes from v1:
 - proto_tree_add_item() now takes pointer to header_field_info *, 
   if NEW_PROTO_TREE_API NOT defined small compatilibity macro is used.
 - convert names just to hfi_ not hfi_hf_
 - fix proto_get_first_protocol_field(), proto_get_next_protocol_field()

Ping, any feedback?

Ok, commited some work based on v2

HFI_INIT for now is just placeholder (to not modify again lots of lines),
later it'll expand to something like: __attribute__((section("_data_hfi_" #proto))) (for gcc/clang),
which will allow to #ifndef hfi[] arrays.

This should also obsolete checkhf.pl cause (at least !windows) compilers will do a check.

I'm not 100% sure how portable __start_section, __stop_section is[1] so
I just need to write some autotools scriptz. Don't know when.

[1] sample how to use __start, __stop: 
http://stackoverflow.com/questions/3808053/how-to-get-a-pointer-to-a-binary-section-in-msvc
    (this is good sample for gcc/clang, I don't know how to do it properly on MSVC).
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]