mailing list archives
Re: [Wireshark-commits] rev 51395: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-rohc.c
From: Pascal Quantin <pascal.quantin () gmail com>
Date: Mon, 19 Aug 2013 12:42:11 +0200
2013/8/17 Jakub Zawadzki <darkjames-ws () darkjames pl>
By the way from ROHC code:
2296 data = (guint8 *)ep_alloc(len);
2299 next_tvb = tvb_new_child_real_data(tvb, data, len, len);
2300 add_new_data_source(pinfo, next_tvb, "Payload");
It's very bad idea to use ep-allocated tvb as data source.
I fixed several dissectors using ep allocated memory for data source in
r51423. I hope I did not miss any.
Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org>
mailto:wireshark-dev-request () wireshark org?subject=unsubscribe