Home page logo

wireshark logo Wireshark mailing list archives

Re: Remove hf_ variables
From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Wed, 7 Aug 2013 19:22:18 +0200


On Wed, Aug 07, 2013 at 09:57:36AM -0400, Jeff Morriss wrote:
On 07/29/13 16:12, Jakub Zawadzki wrote:
There's no real need of them, and we can just replace them with
header_field_info structure.

Just for completeness one should mention that replacing the hf_ 
variables with pointers means that each proto_tree_add_xxx() call will 
be pushing 8 bytes (in what is hopefully by now the common case ;-)) 
instead of 4 bytes onto the stack.

Luckily on x64 windows first 4 arguments (integers or pointers) are passed by registers
(rest of the world - 6). In either case hfinfo won't be passed by stack ;-)
(source: http://en.wikipedia.org/wiki/X86_calling_conventions#Microsoft_x64_calling_convention)
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]