Home page logo
/

wireshark logo Wireshark mailing list archives

Re: r54005 by wmeier for packet-mq.c and packet-mq-pcf.c
From: "RobiOneKenobi" <robionekenobi () bluewin ch>
Date: Sat, 14 Dec 2013 11:30:46 +0100

Yes, 

if it didn't disturb too much people to have such long lines, I will prefer
that you revert this part (hf[] entries reformatting), otherwise I will
follow the majority wishses

-----Original Message-----
From: wireshark-dev-bounces () wireshark org
[mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Bill Meier
Sent: Friday, December 13, 2013 7:08 PM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] r54005 by wmeier for packet-mq.c and
packet-mq-pcf.c

On 12/13/2013 12:21 PM, RobiOneKenobi wrote:
Reformat hf[] entries ?

Why, now all seems no more aligned for me, and your reformat also
left spaces between text and comma.

You're right; I was sloppy about leaving spaces between the text and the 
comma.   :)


I do not agree with such reformat, as it seems less readable as the
one I've put in.


I made the change because, personally, I find the quite long lines quite
difficult to read when they when they exceed the width of my screen
(which I expect they will do on screens used by many).

I like to have some parts aligned to an ease of use for to have the
same length of displayed items.


I understand.

Are there some rules where this is described?



Not really. I do think readability is relevant; I'm not really a fan of 
the old 72 column limit but I do think there should be some limit.

The above notwithstanding, I can revert the hf[] reformatting if you 
desire.....


Bill
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]