Home page logo

wireshark logo Wireshark mailing list archives

Re: Replacing g_iconv and different codesets
From: Guy Harris <guy () alum mit edu>
Date: Fri, 20 Dec 2013 11:35:19 -0800

On Dec 20, 2013, at 11:24 AM, Jakub Zawadzki <darkjames-ws () darkjames pl> wrote:

In euc-kr [1] you can see that it's using ksc5601_to_ucs4() which can be find in ksc5601.h [2].
ksc5601_to_ucs4() is using convertation tables: __ksc5601_hangul_to_ucs, __ksc5601_hanja_to_ucs, __ksc5601_sym_to_ucs
from ksc5601.c [3].

These tables are quite big (about 1K lines) and __ksc5601_sym_to_ucs is using C99 array index initialization
(which you would need to expand (covert to switch?) before commiting).

So I'd rather suggest still using g_iconv() for EUC-KR, but feel free to introduce new ENC_EUC_KR and move it to core.

...and even if we do use g_iconv() for EUC-KR (or anything else), it should ideally be buried in tvb_get_string_enc() 
and so on, rather than directly used in dissectors.
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]