Home page logo

wireshark logo Wireshark mailing list archives

Re: [Wireshark-commits] rev 50197: /trunk/epan/ /trunk/epan/: proto.c
From: Evan Huus <eapache () gmail com>
Date: Thu, 27 Jun 2013 15:28:00 -0400

On Thu, Jun 27, 2013 at 3:17 PM,  <darkjames () wireshark org> wrote:

User: darkjames
Date: 2013/06/27 12:17 PM

 cleanup [u]int fill proto with value_string function

 Create generic int/uint fill functions from hfinfo_[u]int_value_format.

 XXX: to be honest I don't get it why if dev picked up BASE_DEC_HEX and has value string we're truncating it to 

Nesting parentheses? If I recall correctly, BASE_DEC_HEX displays as
dec_val (hex_val), and value strings display as string (value). So if
you use the two together you get string (dec_val (hex_val)) which is a
bit odd. This is just a guess though, I didn't write that code.

Directory: /trunk/epan/
  Changes    Path          Action
  +78 -119   proto.c       Modified

Sent via:    Wireshark-commits mailing list <wireshark-commits () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request () wireshark org?subject=unsubscribe
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]