Home page logo

wireshark logo Wireshark mailing list archives

Re: leaking memory on shutdown
From: Evan Huus <eapache () gmail com>
Date: Thu, 27 Jun 2013 20:22:27 -0400

On Thu, Jun 27, 2013 at 5:25 PM, Jeff Morriss <jeff.morriss.ws () gmail com> wrote:
[Taking discussion out of the bug since it's not specifically related to
that bug.]

On 06/18/13 18:20, bugzilla-daemon () wireshark org wrote:


However, those
protocols currently use glib memory and therefore leak on shutdown,

Isn't that a bit of an oxymoron? :-)

(I know, I know, a while ago I spent a bunch of time cleaning up the
preferences code to avoid leaks on shutdown--I think I commented something
like "I do this just so I know where it is the stuff is being freed.")

But, more seriously, Guy pointed out a (long?) while ago that a certain OS
from a company he knows well has a way for applications to tell the OS
something like "I have nothing to save before exiting" and when that flag is
set and the user closes the app, the OS kills it with SIGKILL: it's faster
and simpler that way.  It's an interesting concept...  It makes me think
that we shouldn't really be spending time trying to fix leaks on shutdown.

The one benefit of fixing leaks on shutdown is that it makes it a
million times easier to detect other (real) leaks because valgrind's
output becomes useful. Right now any valgrind run you do with
--leak-check=full is painfully difficult to analyze because of all the
garbage (and dynamic hf arrays) that count as 'leaks'.

Wmem's epan scope should help a lot in this regard once it ends up
more widely used.

Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]