Home page logo

wireshark logo Wireshark mailing list archives

Re: [Wireshark-commits] rev 49871: /trunk/ /trunk/epan/dissectors/dcerpc/: CMakeLists.txt /trunk/tools/lemon/: lemon.c
From: Guy Harris <guy () alum mit edu>
Date: Mon, 10 Jun 2013 12:03:22 -0700

On Jun 10, 2013, at 11:55 AM, gerald () wireshark org wrote:

tools/lemon/lemon.c: Fix an integer shortening issue. (CMake enables
-Werror here but Autotools doesn't. Which is correct?)

That which causes more errors to be detected and fixed is correct.  I'd turn on -Werror in autotools for lemon, see 
what breaks, and fix it.

epan/dissectors/dcerpc: idl2wrs isn't an installed executable in
Autotools so don't make it one in CMake.

Ronnie said "nuke it":


so should we just delete idl2wrs.c?

Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

  By Date           By Thread  

Current thread:
  • Re: [Wireshark-commits] rev 49871: /trunk/ /trunk/epan/dissectors/dcerpc/: CMakeLists.txt /trunk/tools/lemon/: lemon.c Guy Harris (Jun 10)
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]