Home page logo
/

wireshark logo Wireshark mailing list archives

Re: [Wireshark-bugs] [Bug 6315] Info column to show subMessageIdentifier type strings for H245/H.239 packets
From: Anders Broman <anders.broman () ericsson com>
Date: Wed, 12 Jun 2013 12:07:36 +0000

Hi,
I think I just checked the patch and applied it without too much deliberation, you can revert it if you like.
Regards
Anders


-----Original Message-----
From: Kukosa, Tomas [mailto:tomas.kukosa () siemens-enterprise com] 
Sent: den 12 juni 2013 13:59
To: wireshark-dev () wireshark org; liam.sharp () gmail com; Anders Broman
Subject: RE: [Wireshark-bugs] [Bug 6315] Info column to show subMessageIdentifier type strings for H245/H.239 packets

Hello Anders,

I know it is long time but do not you remember what was an intention and idea behind this patch?

It causes strange info column for H.225 protocol with H.245 inside. H.225 message type is in middle of info text:

Protocol       Info
H.225.0/H.245  masterSlaveDetermination terminalCapabilitySet CS: setup OpenLogicalChannel , Mikey: Pre-shared

How could be H.225 dissector changed to get back previous kind of output?

Protocol       Info
H.225.0/H.245  CS: setup OpenLogicalChannel masterSlaveDetermination terminalCapabilitySet, Mikey: Pre-shared

Best regards,
  Tomas


-----Original Message-----
From: wireshark-bugs-bounces () wireshark org [mailto:wireshark-bugs-bounces () wireshark org] On Behalf Of 
bugzilla-daemon () wireshark org
Sent: Wednesday, September 07, 2011 5:49 PM
To: wireshark-bugs () wireshark org
Subject: [Wireshark-bugs] [Bug 6315] Info column to show subMessageIdentifier type strings for H245/H.239 packets

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6315

Liam Sharp <liam.sharp () gmail com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #6938|                            |review_for_checkin?
               Flag|                            |

--- Comment #1 from Liam Sharp <liam.sharp () gmail com> 2011-09-07 08:48:53 PDT --- Created an attachment (id=6938)  
--> (https://bugs.wireshark.org/bugzilla/attachment.cgi?id=6938)
Patch for review 

Change the top level messages to prepend to the column information. This allows other dissectors to add information at 
dissect time, rather than storing it up as per the pattern used with the OLC's. 

Update the subMessageIdentifier dissector to add extra information for h.239.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]