Home page logo

wireshark logo Wireshark mailing list archives

Re: ** CID 280353: Operands don't affect result (CONSTANT_EXPRESSION_RESULT) /text2pcap.c: 522 in in_checksum()
From: Jakub Zawadzki <darkjames-ws () darkjames pl>
Date: Sun, 9 Feb 2014 11:40:13 +0100

On Sun, Feb 09, 2014 at 10:48:44AM +0100, Toralf Förster wrote:
Furthermore I wonder why an undefined value in epan/crypt/airpdcap_interop.h (around line 98) :

#ifndef ntohs
#undef     ntohs      <--------------
#define ntohs(value)    g_ntohs(value)

has to be undef again ? Or does "#ifndef" also check for a defined, but empty variable ?

I don't think so, it's likely a typo, introduced in r20274 (2.01.2007), so I think '#undef' can be safety removed.

Or better - if this code is not synchronized with 3rd party (CACE/Riverbed) code,
I think we can just use always g_ntohs() there.

Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]