Home page logo
/

wireshark logo Wireshark mailing list archives

Re: Viewing code in Gerrit
From: Evan Huus <eapache () gmail com>
Date: Mon, 24 Mar 2014 12:03:36 -0400

On Mon, Mar 24, 2014 at 11:26 AM, Bill Meier <wmeier () newsguy com> wrote:
On 3/24/2014 9:21 AM, Evan Huus wrote:


In summary: the diff is computed locally in javascript, and seems to
be worse than O(n) on the size of the underlying file; viewing the
diff for any file >1k lines may be slow, but if you just let it run it
will finish eventually. Avoid epan/enterprise-numbers and other files
with 100k+ lines, they take many minutes to finish.


IOW: The 2 versions being diff'd are downloaded in total before doing a
local compare ?

It seems so; however it doesn't appear to be the bandwidth that's the
problem, but the actual diff algorithm. The bottleneck is definitely
CPU.

If so, UGH ....






___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe


  By Date           By Thread  

Current thread:
[ Nmap | Sec Tools | Mailing Lists | Site News | About/Contact | Advertising | Privacy ]