xen: arm: rate-limit logging from unimplemented PHYSDEVOP and HVMOP. These are guest accessible and should therefore be rate-limited. Moreover, include them only in debug builds. This is XSA-146. Signed-off-by: Ian Campbell Reviewed-by: Jan Beulich diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c index 471c4cd..1de290f 100644 --- a/xen/arch/arm/hvm.c +++ b/xen/arch/arm/hvm.c @@ -57,7 +57,7 @@ long do_hvm_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) arg) default: { - printk("%s: Bad HVM op %ld.\n", __func__, op); + gdprintk(XENLOG_DEBUG, "HVMOP op=%lu: not implemented\n", op); rc = -ENOSYS; break; } diff --git a/xen/arch/arm/physdev.c b/xen/arch/arm/physdev.c index 61b4a18..b1ba22e 100644 --- a/xen/arch/arm/physdev.c +++ b/xen/arch/arm/physdev.c @@ -8,12 +8,13 @@ #include #include #include +#include #include int do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) { - printk("%s %d cmd=%d: not implemented yet\n", __func__, __LINE__, cmd); + gdprintk(XENLOG_DEBUG, "PHYSDEVOP cmd=%d: not implemented\n", cmd); return -ENOSYS; }