Re: [Wireshark-commits] rev 40601: /trunk/epan/ /trunk/epan/: packet.c packet.h

[Anders Broman <anders.broman () ericsson com>]

-----Original Message-----
From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Guy Harris
Sent: den 20 januari 2012 05:53
To: wireshark-dev () wireshark org
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 40601: /trunk/epan/ /trunk/epan/: packet.c packet.h


On Jan 19, 2012, at 6:43 PM, wmeier () wireshark org wrote:

> > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=40601
> >
> > User: wmeier
> > Date: 2012/01/19 06:43 PM
> >
> > Log:
> > Add 'heur_dissector_set_enabled()' to allow a dissector to 
> > enable/disable heuristic dissection; Rename some vars; Do some minor 
> > re-indentation and whitespace changes.
>
> Hmm.
>
> Should this be done from the enable/disable dissectors dialog?  E.g., if a protocol has both key-based (uint or string 
> or whatever we add in the future) and 
> heuristic dissectors, should there be checkboxes to control the key-based and heuristic dissectors, and if it has only 
> a heuristic dissector, should there be an 
> entry for it?

I have half finished code to add enable dissable heuristics dissectors from the enable/disable dissectors dialog 
sitting on my home computer. I can
Submitt that code on Sunday at the earliest.
Regards
Anders
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe