[PATCHed] Using dnet headers for TCP and UDP

[Kris Katterjohn <katterjohn () gmail com>]

Kris Katterjohn wrote:
> The attached patch (/nmap-exp/kris SVN r4373) does some more dnet header
> "converting". This one handles the IP stuff. SVN log:
>
> ------------------------------------------------------------------------
> r4373 | kris | 2007-01-21 18:51:50 -0600 (Sun, 21 Jan 2007) | 1 line
>
> More dnet header standardizing. This changes the IP stuff over, and
> modifies dnet slightly. It removes the netinet/ip.h references from
> nmap.h and tcpip.h, the struct ip from tcpip.h, and converts struct ip
> -> struct ip_hdr everywhere. It all compiles and runs fine for me, and
> hopefully for everyone else too.
> ------------------------------------------------------------------------

Okay, Fyodor and I got to talking about this IP stuff and came to the
conclusion that, like the ICMP stuff, it's too much of a hassle to
switch over. I merged the TCP and UDP changes into /nmap , and here's
the SVN log:

------------------------------------------------------------------------
r4379 | kris | 2007-01-22 23:29:59 -0600 (Mon, 22 Jan 2007) | 1 line

Use dnet headers for TCP and UDP. This allows us to remove netinet tcp.h
and udp.h references, the udphdr_bsd stuff, and the TH_ECE/TH_CWR
#defines in tcpip.h. That was easy, but we (Fyodor and I) came to the
conclusion that IP and ICMP aren't worth the hassle to switch (I was
testing TCP, UDP and IP in my branch). The struct icmp_hdr in dnet isn't
setup anything like what we're using now. Then, struct ip_hdr uses
ip_addr_t (typedef'd to uint32_t in that ip.h) instead of struct in_addr
for the IP addresses, and that would require some dnet modifying to work
right. We might be able to come up with some elegant solution for IP,
but probably not for ICMP. For now, they're still left up to netinet (or
tcpip.h).
------------------------------------------------------------------------


Thanks,
Kris Katterjohn

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org