Bug in XML output

[Netcraft Security <security () netcraft com>]

Fyodor,

There seems to be an important omission in nmap's XML output code, which means that the 
first OS guess isn't reported. The problem seems to have been around since 2.54BETA6 and 
remains in 4.22SOC6. The cause is a missing log_write(LOG_XML ...) for the initial OS 
guess when "Aggressive" guesses are output:

[4.22SOC6 output.cc, line 1478]

       if ((o.osscan_guess || reason) && FPR->num_matches > 0) {
         /* Print the best guesses available */
         log_write(LOG_PLAIN,"Aggressive OS guesses: %s (%d%%)", 
FPR->prints[0]->OS_name, (int) (FPR->accuracy[0] * 100));

---> Missing log_write(LOG_XML, ...) for the first guess here

         for(i=1; i < 10 && FPR->num_matches > i && FPR->accuracy[i] > FPR->accuracy[0] 
- 0.10; i++) {
           char *p;
           log_write(LOG_PLAIN,", %s (%d%%)", FPR->prints[i]->OS_name, (int) 
(FPR->accuracy[i] * 100));
           log_write(LOG_XML, "<osmatch name=\"%s\" accuracy=\"%d\" line=\"%d\"/>\n",
                     p = xml_convert(FPR->prints[i]->OS_name),
                     (int) (FPR->accuracy[i] * 100),
                     FPR->prints[i]->line);
           free(p);
         }
         log_write(LOG_PLAIN, "\n");
       }


Regards,

Martyn Tovey

-- 
Netcraft, 2 Belmont, BATH, Somerset, BA1 5DZ, UK.

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org