Re: [RFC] Username/Password NSE library

[Kris Katterjohn <katterjohn () gmail com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Patrick Donnelly wrote:
> I just want to repeat what I said in reply to Thomas:
>
> The performance difference between the two is almost negligible and
> certainly will not impact anything. It has become more of an aesthetic
> difference. If you have good reasons for not using the generic for
> loop then by all means please don't :)

I was confused because you made a lot of changes, one of which had the "main
advantage" of a negligible performance difference :)

I do agree that the for loop method looks a bit cleaner, but that interface is
only good if it's used in that loop (and I don't think every script will).

I was also thrown off by the error() in your patch that didn't seem to do
anything (was that for some other use case?)

> Cheers,

Thanks,
Kris Katterjohn

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIVAwUBSGMLFf9K37xXYl36AQJEiQ/9G/vQ5gopa8X5MObUCF/cXwLoji4Q7b/m
tD2v1+MOh2r4wtCiDcE4cVF7CUbZnpvWB4ayNKcSpO546ad9JZN7iBbJ2uBtoBK8
VjuQoy4pVU1zDB3gxEKB5Xz+BXG1rCes5OVDr3/HlKRADd9dZsRaHfmB8/pT0zId
YDbHY0Vq6VrVNa0vxECRsPwOrELELc79BZb25xla34cmmAId3asMYR3pb/yt2r+J
1X5cWHAyfwxd5a/pXv8pt3vl1GXrFrXxkDbx+fsvL7/gZCwqSr9RYp057vxN1zqo
9skgVJ9toXejWbT0L0C64mrQEqxuSIirRwO+VZUHBIBwlR9CYCVzD2OU2k3WrJNo
0Z3fF7M5mX4bNjyUh1eIVFF56SXNKEG9hNrLkiAMpIMIU4dLh0QC3iZ+LN6cGiQk
skJejIsH0MObPui3kPNE76LX1YSnHZQRcvabuvYAYvWaU3b3f27BcLRfFcmFeXL4
tbBZ7bAqnR6BP86Cu/SE+2wqLe/CLdPt9KQPFArIgaWjKAL/WEVTRl81+9HLrJen
o495SN0FCDJyEx33FSMLFpkTtM0dUDWOFiqmE2ocche/RPSMDqiFvO/bcTiBx74w
iBrcvieqj2XMQ6AsYM0b0eN9X96Ks/oOT3/MuH3XyHrGBUp/HkHTYldB9O60jPp9
p6/myv5Thgc=
=ERYu
-----END PGP SIGNATURE-----

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org