Re: [PATCH] [Ncat] Add address family hint to resolve()

[Daniel Roethlisberger <daniel () roe ch>]

David Fifield <david () bamsoftware com> 2009-04-30:
> On Thu, Apr 30, 2009 at 11:20:21PM +0200, Daniel Roethlisberger wrote:
> > The attached patch fixes Ncat on BSD libc platforms, where bugs
> > in getaddrinfo(3) until recently have prevented Ncat to resolve
> > hostnames to addresses due to the combination of used parameters,
> > especially in combination with the numerical service name and no
> > socket type hint provided.  Since we provide a numerical service
> > name, the actual socket type given does not matter.
>
> Thanks Daniel. It works for me on GNU/Linux.

I committed the fix.

> Does the function resolve_name in ncat_hostmatch.c need this
> too?

Not according to test-addrset.sh, which passes all tests.  Not
sure though whether this really covers resolve_name() very well.

-- 
Daniel Roethlisberger
http://daniel.roe.ch/

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org