Re: [PATCH] Match line update for Famatech Radmin remote control

[Brandon Enright <bmenrigh () ucsd edu>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue, 09 Jun 2009 17:56:54 -0500
Tom Sellers <nmap () fadedcode net> wrote:

> The attached patch updates the match lines for the Famatech Radmin
> remote control product.
>
> The patch:
>
> 1.  Adds two additional match lines for Radmin 3.x.
> 2.  Updates and fixes the general Radmin softmatch line.
> 3.  Adds a match line for when the product is configured with
>      IP filtering and the scanning machine is not permitted access.
>
> Tom

Hey Tom, this patch looks really good but before I check it in, I have
a question about the softmatch.

Is "m|^\x01\x00\x00\x00\x25|" broken?  Your change to
"m|^\x01\x00\x00\x00.{3}\x02\x12\x08\x02|" is a lot more specific.  Is
there a case where the original would match but your change won't?

Brandon

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (GNU/Linux)

iEYEARECAAYFAkou7/EACgkQqaGPzAsl94JLCQCeJw089GpcFkarBT9MT087iLB0
wuUAnAzpzltGXzN+au4hNdE9BLY8eYqW
=TfaN
-----END PGP SIGNATURE-----

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org