RE: [PATCH] nmap-service-probes: Misc database corrections, printer additions

[Aaron Leininger <rilian4 () hotmail com>]

> I think this script can be included. I have some suggestion.
>
> To fit in with the naming conventions of the other script, it should
> have a name like pjl-ready-message. The id variable is no longer used
> and should be removed.
>
> The name "msg" is too general for the script arg name. Maybe it can be
> pjl.ready-message or pjl-ready-message.message. Those are a bit long,
> but it should be something that identifies it as belonging to this
> script.
>
> For example usage and script args, use NSEDoc like this:
> ---
> -- @arg pjl.ready-message Ready message to display.
> -- @output
> -- 9100/tcp open  jetdirect
> -- |_ hprdymsg: "p0wn3d pr1nt3r" was set as the display for printer at 10.4.10.77
> -- @usage
> -- nmap --script=pjl-ready-message.nse \
> --   --script-args='pjl.ready-message="your message here"'


I'll try to put all of this into a revision of the script. Thanks for thinking it worthy of being included. 



> Does the port return any message to say whether the message was set
> successfully? If so you should check it and state the result in the
> return value. Otherwise it could be a discard server on port 9100 and
> the script will still say "'...' was set as the display". comm.exchange
> is an easy way to make a transaction like this.


As far as I can tell, there is no return message from the port. You
send the command and the display is set. I will run some further packet
dumps to confirm this. 


-Aaron
_________________________________________________________________
Insert movie times and more without leaving Hotmail®. 
http://windowslive.com/Tutorial/Hotmail/QuickAdd?ocid=TXT_TAGLM_WL_HM_Tutorial_QuickAdd_062009

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org