Re: [NSE] rpc library

[David Fifield <david () bamsoftware com>]

On Mon, Apr 12, 2010 at 01:37:31AM +0100, Djalal Harouni wrote:
> hi, attached are patches for rpc.lua lib, rpcinfo.nse and nfs-*.nse
> scripts
>
> 1) rpc.lua lib
> - better Comm:new() error handling.
> - two new methodes: ChkVersion(): to check if the lib support the rpc
>   protocol version, and SetVersion() to set rpc versions.
> - fixed some left open sockets.
>
> 2) nse scripts which use the rpc.lua lib:
> - better error output for rpcinfo.nse and nfs-*.nse scripts
>
> ex:./nmap -p111 -PN -n -d1 --script scripts/nfs-dirlist.nse
> --script-args="nfs.version=4" 192.168.100.101
>
> PORT    STATE SERVICE REASON
> 111/tcp open  rpcbind syn-ack
> | nfs-dirlist:
> |   /mnt/nfs/files
> |     ERROR: rpc.Helper.Dir: RPC library does not support: nfs version 4
>
> Reminder:
> when adding NFSv4 support we must update the nfs and mountd versions
> mismatch check.

Hello, Djalal. I am looking at the rpc.lua patch. It's hard for me to
see what the patch changes because in addition to functional changes,
you've altered the layout of the file. For example, here is the same
method in the old and new files:

Comm = {
        SendPacket = function( self, packet )
                return self.socket:send( packet )
        end,
}

function Comm:SendPacket(packet )
        return self.socket:send(packet)
end

These are the same function, but they appear as differences in the
patch. So I can't see what's really changed. I must ask you, if you
will, to redo your changes without changing the layout of the file more
than is necessary. Then coding style changes can be done as a separate
patch.

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/