Re: Wrong time unit in "-h" output.

[Fyodor <fyodor () insecure org>]

On Fri, Jul 16, 2010 at 10:40:58AM +0200, Luis MartinGarcia. wrote:
> Hi,
>
> I've detected that both Nmap and Nping still say that the default time
> unit is milliseconds. This is in the output of "nmap -h". I've changed
> Nping's output already. I'm 99% sure this is a bug for Nmap too but I'm
> sending the patch here before committing it, just in case I'm wrong. If
> anyone has something against this "speak now or forever hold your peace".

Good catch!  There is a minor issue with this wording:

+       "  Options which take <time> are in seconds, unless you explicitly append 'ms'\n"
+       "  (milliseconds), 's' (seconds), 'm' (minutes), or 'h' (hours) to the value\n"
+       "  (e.g. 30m, 0.5s, 0.25h).\n"

The combination of "in seconds, unless" and including "seconds" in the
qualifier list is a bit weird, but I don't immediately see a better
way to word it while still being as concise and clear.  I do want to
keep 's' in the list for now as it allows for compatibility with the
old syntax.  So I'd say just apply your patch and we can always tweak
the wording later if necessary.

Cheers,
-F
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/