Re: [nmap-svn] r19501 - nmap-exp/luis/nping-echo

[David Fifield <david () bamsoftware com>]

On Thu, Aug 05, 2010 at 05:51:18PM -0700, commit-mailer () insecure org wrote:
> Author: luis
> Date: Thu Aug  5 17:51:18 2010
> New Revision: 19501
>
> Log:
> Fixed a problem that caused Nping to abort on Windows due to a stack
> overflow. After hours looking for the problem, I found that it was
> Visual Studio's fault because by default it only allocates 1MB stacks.
> Incrementing this value to 5MB (quite reasonable for today's RAMs)
> does the trick.
>
> Modified:
>    nmap-exp/luis/nping-echo/nping.vcproj
>
> Modified: nmap-exp/luis/nping-echo/nping.vcproj
> ==============================================================================
> --- nmap-exp/luis/nping-echo/nping.vcproj     (original)
> +++ nmap-exp/luis/nping-echo/nping.vcproj     Thu Aug  5 17:51:18 2010
> @@ -82,6 +82,7 @@
>                               GenerateDebugInformation="true"
>                               ProgramDatabaseFile=".\Debug/nmap.pdb"
>                               SubSystem="1"
> +                             StackReserveSize="5000000"
>                               OptimizeForWindows98="0"
>                               RandomizedBaseAddress="1"
>                               DataExecutionPrevention="0"

Interesting. Do you have any idea how the stack gets that deep in the
first place?

David Fifield
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/