Nsock does not pcap_close()

["Luis MartinGarcia." <luis.mgarc () gmail com>]

Hi,

I've been debugging Nping with Valgrind and I've noticed that Nsock does
not close the pcap descriptor in nsp_delete() nor it offers something
like nsock_pcap_close(). This is not a big deal at all but I think it
would be nice to improve pcap handling a little so valgrind doesn't
display things like:

Consider implementing a nsock_pcap_close() function or making
  nsp_delete() call pcap_close() when pcap IODs are used. Currently valgrind
  warns about a socket descriptor left opened (at least in Nping).
  ==10526==    at 0x62F77A7: socket (syscall-template.S:82)
  ==10526==    by 0x4E348A5: ??? (in /usr/lib/libpcap.so.1.0.0)
  ==10526==    by 0x4E36819: pcap_activate (in /usr/lib/libpcap.so.1.0.0)
  ==10526==    by 0x4E375FC: pcap_open_live (in /usr/lib/libpcap.so.1.0.0)
  ==10526==    by 0x4311A9: nsock_pcap_open (nsock_pcap.c:64)
  ==10526==    by 0x428078: ProbeMode::start() (ProbeMode.cc:329)

[This is not shown in normal output, just when passing --track-fds=yes]

Regards,

Luis MartinGarcia.
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/