Re: [NSE] [Call for Testers] Nsock Library Binding Improvements

[Patrick Donnelly <batrick () batbytes com>]

Some things I forgot to mention:

On Tue, Sep 14, 2010 at 3:19 AM, Patrick Donnelly <batrick () batbytes com> wrote:
> Changes in this branch (developers and the curious should read):
>
> == General ==
>
> [...]

o The nsock_pool structure is no longer static. It is a regular Lua
userdatum that is collected when the Lua state is closed.
o All malloc'd memory is changed to Lua generic userdata. This
prevents possible leaks when an unexpected error is thrown.

> Interesting statistics:
>
> Lines added: 1323
> Lines removed: 2049
>
> batrick@batbytes:~/nmap/svn/nmap$ wc -l nse_nsock.cc
> 2264 nse_nsock.cc
> batrick@batbytes:~/nmap/svn/patrick/nse-nsock-maintenance$ wc -l nse_nsock.cc
> 1072 nse_nsock.cc
> batrick@batbytes:~/nmap/svn/patrick/nse-nsock-maintenance$ wc -l nse_dnet.cc
> 308 nse_dnet.cc

In nse_nsock.cc: code for Lua 5.1 that will be removed when Lua 5.2 is
integrated: 100 lines

In nse_nsock.cc: code for Lua 5.2 that will become active: 212 lines.
This brings nse_nsock.cc net lines of code when Lua 5.1 specific code
is removed to 972 lines.


-- 
- Patrick Donnelly
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/