[Patch] ncat/ncat_exec_win.c

[Gisle Vanem <gvanem () broadpark no>]

ncat/ncat_exec_win.c: start_subprocess() refers to an (at first pass) 
unknown structure 'subprocess_info'. When compiling with 'g++', this trips 
an error. Hence the struct-definition should be moved further up:

--- ncat/ncat_exec_win.c        Sat Nov 20 16:56:02 2010
+++ ncat/ncat_exec_win.c     Sat Nov 20 20:11:38 2010
@@ -98,9 +98,6 @@
   a thread. Protects subprocesses and subprocesses_max_index. */
static HANDLE subprocesses_mutex = NULL;

-static int start_subprocess(char *cmdexec, struct subprocess_info *info);
-static DWORD WINAPI subprocess_thread_func(void *data);
-
static int register_subprocess(HANDLE proc);
static int unregister_subprocess(HANDLE proc);
static int get_subprocess_slot(void);
@@ -127,6 +124,9 @@
    HANDLE child_out_r;
    HANDLE child_out_w;
};
+
+static int start_subprocess(char *cmdexec, struct subprocess_info *info);
+static DWORD WINAPI subprocess_thread_func(void *data);

/* Run a child process, redirecting its standard file handles to a socket
   descriptor. Return the child's PID or -1 on error. */

--------------

BTW. It would be nice if all the source/header names could be unique. This would
ease using a single monolithic makefile as I have done for MingW. I'd like these
files to be renamed if possible:
nping/output.cc -> nping/nping_output.cc
nping/utils.cc  -> nping/nping_utils.cc
nping/winfix.cc -> nping/nping_winfix.cc


--gv
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/