Re: [NSE][patch] Replace superfluous uses of the NSE registry

[Patrick Donnelly <batrick () batbytes com>]

On Mon, Jun 20, 2011 at 4:42 PM, Henri Doreau
<henri.doreau () greenbone net> wrote:
> Hi,
>
> please find attached a patch for firewalk.nse, ipidseq.nse and
> qscan.nse. These scripts use the registry to transfer information
> between the hostrule and the action function.
>
> The patch replaces this code by the use of a global variable in each
> script in order to avoid bloating the registry
>
> Just wanted NSE experts approval/comments before checking it in.

This is a good patch.

To be pedantic, those are not global variables. They are local
variables to the file scope. [A file is simply an anonymous vararg
function: function (...) <chunk> end] Local variables are always a
better choice over global variables except in extremely rare
circumstances.

-- 
- Patrick Donnelly
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/