Re: xmpp.nse

[Henri Doreau <henri.doreau () greenbone net>]

2011/5/15 Vasiliy Kulikov <segooon () gmail com>:
> Hi,
> [...]
>
> Any corrections and suggestions are welcome.
Hello Vasiliy,

thanks for this nice update! I especially like the fact that you added
references to the official XMPP documentation for the extensions. I am
still testing and reviewing it but already have some thoughts I would
like to share.

My first concern is about the maintainability of the script. That
would probably make sense to split part of it into a XMPP library (see
nselib/*.lua for the existing ones) and a fingerprint file...
In the other hand it is also fine to have everything in a single
script as it's our only XMPP related NSE but I'm afraid it might be
difficult to update/maintain.

When testing the script against jabber.ccc.de I got the following output:
"""
Host is up (0.043s latency).
PORT     STATE SERVICE
5222/tcp open  xmpp-client
| xmpp:
|     XMPP
|       lang: en
|       v1.0
|     features
|       In-Band Registration
|       TLS
|     capabilities
|       node: http://www.process-one.net/en/ejabberd/
|       ver: o8zQAtrb2wELMmZizvbnpvqp5cE=
|     AUTH MECHANISMS (2)
|       PLAIN
|       DIGEST-MD5
|     Unknown features (please report about it on nmap-dev@)
|       c
|_  Respects server name
"""
I guess that this "c" tag shouldn't end there... Am I wrong?

It would also be nice to get around the TODO points... What about
defining a "policy" to react consistently against these unexpected
replies?

If someone else could review this patch, I would really appreciate to
read another point of view.

> Thanks,
>
> --
> Vasiliy

Regards.

-- 
Henri Doreau |  Greenbone Networks GmbH  |  http://www.greenbone.net
Neuer Graben 17, 49074 Osnabrueck, Germany | AG Osnabrueck, HR B 202460
Executive Directors: Lukas Grunwald, Dr. Jan-Oliver Wagner
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/