Re: [NSE] ip-geolocation

[Patrick Donnelly <batrick () batbytes com>]

On Fri, Jun 10, 2011 at 11:36 AM, Gorjan Petrovski <mogi57 () gmail com> wrote:
> Hi,
>
> Please find attached the ip-geolocation script. I've implemented IP
> geolocation lookups on 4 web services(Geoplugin, IPInfoDB, Geobytes
> and Quova) and a query against a Maxmind database based on the API
> from Maxmind.
>
> The usage is as follows:
> nmap --script ip-geolocation <target> [--script-args
> ip-geolocation.{[quova],[geobytes],[ipinfodb],[geoplugin],[maxmind_db],[maxmind_db=<filename>],[maxmind_only]}]


Couple comments on the code:

o The gmtime() function can simply be:

os.time(os.date("!*t"))

I think there was also an error somewhere in your gmtime function
because the two produce different results.

o The name for your "const" table worries me. Can you change it to
something else that doesn't resemble a C keyword? :)


Overall I like the script. Is there a reason you didn't elect to go
with separate scripts with "subnames" [1].

[1] http://seclists.org/nmap-dev/2011/q2/794

-- 
- Patrick Donnelly
_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://seclists.org/nmap-dev/